Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer span over div for the default template #18

Open
oliviertassinari opened this issue Jul 8, 2020 · 2 comments
Open

Prefer span over div for the default template #18

oliviertassinari opened this issue Jul 8, 2020 · 2 comments

Comments

@oliviertassinari
Copy link

The following HTML structure is invalid: p > div, the following is valid: p > span.

@oliviertassinari oliviertassinari changed the title Prefer span over div for the default templte Prefer span over div for the default template Jul 8, 2020
@agjohnson
Copy link
Contributor

I don't believe we output any <p> elements in our placements. Are you noticing otherwise, or is the case that you are surrounding the <div> in a <p> on your site?

We currently treat both text and image placements as a block elements anyways -- and both have nested block elements -- so a <div> is still probably the most semantically correct. If it's possible, it's probably best to just avoid the surrounding <p> element.

@oliviertassinari
Copy link
Author

oliviertassinari commented Jul 9, 2020

@agjohnson To provide more context on the problem, we render the ad on a p element, it's a constraint we can't change. I was leaning toward using the API raw, but it throws a CORS issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants