Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to close standard ad formats #43

Open
ericholscher opened this issue Dec 17, 2020 · 3 comments
Open

Make it possible to close standard ad formats #43

ericholscher opened this issue Dec 17, 2020 · 3 comments

Comments

@ericholscher
Copy link
Member

I think it would be good to be able to close the ads. Some of our publishers have implemented this themselves, but we should at least make having it be "closable" an option, if not the default for all our client implementations.

One design decision is whether to also have this not display ads to this user for some period of time. Perhaps set a 1hr cookie on the user with this preference on the site they are browsing? This goes against our "no cookies" marketing, but I think this seems like a pretty benign one.

@ericholscher
Copy link
Member Author

@davidfischer thoughts on this one? If it isn't a lot of work, I think this is probably worth doing soonish, just to show good will in the community.

@davidfischer
Copy link
Contributor

I think closing is fine. I don't think we should set any cookies at all -- even 1 hour ones. I think it will just yield complicated messaging.

@davidfischer
Copy link
Contributor

#94 has an example of a close-able ad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants