Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console logs into the websites that are using ethical ads #58

Open
karthikdivi opened this issue Apr 30, 2021 · 3 comments
Open

Console logs into the websites that are using ethical ads #58

karthikdivi opened this issue Apr 30, 2021 · 3 comments

Comments

@karthikdivi
Copy link

Started seeing the following console logs in the websites that are using EthicalAds

EthicalAds detected keywords:{}
It's better to enable this by a debug flag (may be including a debug version of the .js file) instead coming by default.

@ericholscher
Copy link
Member

@karthikdivi We'd like to make this accessible to our users and ourselves for debugging. It's currently under a console.debug, which generally gets filtered out by default. Is there a better way to make it accessible to users but not have it impact your use case?

@karthikdivi
Copy link
Author

@ericholscher If it's an easy change, my suggestion would be giving this flag to users so that they can disable if they want. Something like below
<div data-ea-publisher="..." data-ea-type="text" data-ea-logs="false" ></div>

@ericholscher
Copy link
Member

@karthikdivi That's a great idea. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants