Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add form element explaining why email login is disabled #330

Open
Tracked by #312
agjohnson opened this issue Apr 5, 2024 · 0 comments
Open
Tracked by #312

Add form element explaining why email login is disabled #330

agjohnson opened this issue Apr 5, 2024 · 0 comments
Labels
Needed: design decision A core team decision is required

Comments

@agjohnson
Copy link
Contributor

agjohnson commented Apr 5, 2024

I am pushing this issue off to later. I did give a try at showing a tooltip on a disabled menu item, but the combination of a menu, disabled item, and tooltip don't play together.

Normally, when using the disabled variant of many elements, this will disable all mouse events, including mouse events to child elements.

It is possible to do something like this however:

<div data-tooltip="This will show">
  <a class="ui disabled button">Even though this is disabled</a>
</div>

However, the nested structure of .ui.menu and .ui.menu.item are important and this workaround causes more edge cases. I also tried putting the tooltip on the .ui.menu which did technically work, but was a bit weird.

I think the disabled state is probably fine. If we get any confusion on this, it might be worth enabling the menu item and putting a form error on a disabled form. I could see how this would just be a confusing extra click too though.

@agjohnson agjohnson mentioned this issue Apr 5, 2024
10 tasks
@agjohnson agjohnson added the Needed: design decision A core team decision is required label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

1 participant