Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A button for removing highlight content from the page #816

Closed
dojutsu-user opened this issue Sep 10, 2019 · 2 comments
Closed

A button for removing highlight content from the page #816

dojutsu-user opened this issue Sep 10, 2019 · 2 comments

Comments

@dojutsu-user
Copy link
Member

dojutsu-user commented Sep 10, 2019

It would be nice to have a button or something else which removes the highlighted content from the page.

63571884-243d9b80-c59f-11e9-9fbf-b0f34f6533c8
(link: http://2.python-requests.org/en/master/user/quickstart/?highlight=payload#passing-parameters-in-urls)

Ref: readthedocs/readthedocs.org#6087

@agjohnson
Copy link
Collaborator

I missed the underlying change here. I'm -1 on this change and -1 on the underlying removal of the search highlighting. The link in this case is not easy to find for users, it is superfluous for most users, and there is better UX to display that we are showing search results. Additionally, search results should be able to highlight across themes in similar ways, so this is an RTD problem.

We need to revisit the search highlighting in RTD, there are better ways to accomplish whatever problem we were hitting with search. Going to close this as I don't think this is a good answer and would be a theme dependent fix to a platform problem.

@mgeier
Copy link
Contributor

mgeier commented Feb 3, 2020

See #876 for a possible implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants