Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pricing page polish #167

Open
2 of 10 tasks
agjohnson opened this issue Nov 10, 2022 · 4 comments
Open
2 of 10 tasks

Pricing page polish #167

agjohnson opened this issue Nov 10, 2022 · 4 comments
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@agjohnson
Copy link
Contributor

agjohnson commented Nov 10, 2022 •
edited

A few points that I accumulated from #166 for a second pass, eventually:

  • Hide feature list table on mobile, it looks awful stacked
  • Set a min-height on the community/commercial plans tabs so that page content doesn't jump when switching tabs
  • Linking to either community/commercial tab should also focus the tab. Currently, it just switches the tab and doesn't scroll up
  • Track enterprise contact us with analytics -- add a form somewhere to link to?
  • Add commercial plan commentary back to each plan -- "good for private docs.." etc. See Rework pricing page #166 (comment)
  • Do something different with community plan in feature listing? This is currently enabled, but under a feature flag of sorts.
  • Consider potential reordered feature list, weigh sorting by plan vs sorting by feature category and context -- Rework pricing page #166 (comment)
  • Location of single line community plan callout -- above or below plan listing? This was originally more of a toast at the top of the page
  • Mobile table sticky header row doesn't scroll horizontally. Probably just still remove the table on mobile entirely
  • Highlight feature table column in some way when linking from plans above
@agjohnson agjohnson added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Nov 10, 2022
@agjohnson agjohnson mentioned this issue Nov 14, 2022
Merged
2 tasks
@humitos
Copy link
Member

humitos commented Nov 16, 2022

I'm not sure if this effect is on purpose or not, so, I'm commenting here.

When I click on the "Pricing" link, it goes to the pricing page and automatically scrolls down to the pricing table. Which I find a little "aggressive" (not sure if that's the correct word) --but I personally don't like the page moving it automatically by itself.

Peek 2022-11-16 10-14

@agjohnson
Copy link
Contributor Author

Ah good catch, this is a regression from earlier on in my work. It's not intended, the JS that controls this probably should track user actions more aggressively. I'll treat this issue as a bug and get a fix out

agjohnson added a commit that referenced this issue Nov 16, 2022
@agjohnson
Fix pricing page scrolling
fe69902 
A scrolling/focus issue was noted in #167. The error was unconditionally
scrolling to the pricing plan blocks. The logic that we want is to only
scroll to the plans if they are not on the page currently, and only when
some action has selected one of the tabs (there is a URL hash).
@agjohnson agjohnson mentioned this issue Nov 16, 2022
Merged
agjohnson added a commit that referenced this issue Nov 21, 2022
@agjohnson
Fix pricing page scrolling (#171)
3b72f18 
A scrolling/focus issue was noted in #167. The error was unconditionally
scrolling to the pricing plan blocks. The logic that we want is to only
scroll to the plans if they are not on the page currently, and only when
some action has selected one of the tabs (there is a URL hash).
@humitos
Copy link
Member

humitos commented Nov 23, 2022

Would it be possible (and useful?) to highlight the column of the specific plan when we click "See all features"?

Screenshot_2022-11-23_18-50-29

@agjohnson
Copy link
Contributor Author

Yeah, this would be possible, it waffled on putting this in the first iteration. It would be a good addition, but might take some custom code. I'll note this above though 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@humitos @agjohnson