Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post: How do use vale with RTD #274

Open
ericholscher opened this issue Mar 7, 2024 · 5 comments
Open

Blog post: How do use vale with RTD #274

ericholscher opened this issue Mar 7, 2024 · 5 comments

Comments

@ericholscher
Copy link
Member

We should eventually add a linting step to builds, but lots of people want "linting", we should help them figure this out.

@humitos
Copy link
Member

humitos commented Mar 9, 2024

We've got a PR to setup codespell in our repository in readthedocs/readthedocs.org#11195. Maybe something to consider here as well.

@humitos
Copy link
Member

humitos commented Mar 9, 2024

One thing that I was thinking about this was: "do we want to run these lintings on Read the Docs and fail the build because of that?". I remember we used to have Sphinx's lincheck in our build workflow and we got tired of it because the build failed and we weren't able to see the preview or similar.

Maybe the vale/codespell check is a little different since with linkcheck we don't have control on the external links and it's a bit tedious that your build fails because something you didn't touch. However, spell checks are more related with the actual PR itself where the user has 100% control over it.

Thoughts?

@ericholscher
Copy link
Member Author

I think it would work similar to our other build steps, where a non-zero exit code would fail the build.

@humitos
Copy link
Member

humitos commented Mar 12, 2024

Right, that's my point. Do we want to fail the whole build just because a typo? Would that be a good UX?

@ericholscher
Copy link
Member Author

ericholscher commented Mar 12, 2024

Presumably the tool would allow you to configure this? I don't think we want to change our expectations, but guide users into configurations that do what they want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants