numeric NumericParseError(Underflow)

[readyset-railway]

Summary

numeric data type with large floating points cause Readyset replicator to raise an NumericParseError(Underflow) error and goes into a loop.

Steps to reproduce

CREATE TABLE t1 (a numeric(1000,800));

INSERT INTO t1 VALUES ('85243.39540024977626076239847863600785982737155858270959890014613035727868293618673807776733416230953723818527101593495895350807775607346277892835514324320448949370623441059033804864158715021903312693889518990256881059434042443507529601095150710777634743301398926463888783847290873199395304998050753365215426971278237920063435565949203678024225270616295573678510929020831006146661747271783837653203039829647102027431761129518881525935216608429897041525858540380754759125150233053469999022855035');

ReadySet version

359b727a7c016c3975ff946201cd9a48f215f448

Upstream DB type and version

Postgres 16

Logs

2024-03-13T13:37:18.972957Z ERROR replicators::noria_adapter: Will stop replicating a table due to table error table="public"."t1" error=Error during replication: WAL error: NumericParseError(Underflow)
2024-03-13T13:37:18.973374Z  INFO replicators::noria_adapter: Removing table state from readyset table="public"."t1"
2024-03-13T13:37:18.975248Z  INFO replicators::table_filter: denying replication schema=public table=t1
2024-03-13T13:37:18.976174Z  WARN replicators::noria_adapter: Restarting adapter after error encountered error=Internal error: invariant failed: lsn == cur_pos.commit_lsn;
left = 0/43AC9530;
right = 0/43AC91F8
2024-03-13T13:37:18.976203Z ERROR replicators: Error in replication, will retry after timeout error=Internal error: invariant failed: lsn == cur_pos.commit_lsn;
left = 0/43AC9530;
right = 0/43AC91F8 timeout_sec=1
2024-03-13T13:37:19.994644Z  INFO replicators::postgres_connector::ddl_replication: Setting up DDL replication
2024-03-13T13:37:19.995736Z  INFO tokio_postgres::connection: NOTICE: schema "readyset" already exists, skipping
2024-03-13T13:37:20.004322Z  INFO replicators::postgres_connector::ddl_replication: Set up DDL replication
2024-03-13T13:37:20.009966Z  INFO replicators::noria_adapter: Connected to PostgreSQL
2024-03-13T13:37:20.012231Z  INFO replicators::noria_adapter: readyset_slot_exists full_resnapshot=false resnapshot=false pos=Some(0/43AC93C0)
2024-03-13T13:37:20.014147Z  INFO replicators::postgres_connector::connector: confirmed_flush_lsn="0/43AC7AE8" wal_status="reserved"
2024-03-13T13:37:20.016993Z  INFO replicators::noria_adapter: Streaming replication started
2024-03-13T13:37:20.018173Z ERROR replicators::noria_adapter: Will stop replicating a table due to table error table="public"."t1" error=Error during replication: WAL error: NumericParseError(Underflow)
2024-03-13T13:37:20.018211Z  INFO replicators::noria_adapter: Removing table state from readyset table="public"."t1"
2024-03-13T13:37:20.019525Z  INFO replicators::table_filter: denying replication schema=public table=t1
2024-03-13T13:37:20.019666Z  WARN replicators::noria_adapter: Restarting adapter after error encountered error=Internal error: invariant failed: lsn == cur_pos.commit_lsn;
left = 0/43AC9530;
right = 0/43AC91F8
2024-03-13T13:37:20.019697Z ERROR replicators: Error in replication, will retry after timeout error=Internal error: invariant failed: lsn == cur_pos.commit_lsn;
left = 0/43AC9530;
right = 0/43AC91F8 timeout_sec=1