Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run React Native integration tests in more configurations #6604

Open
kraenhansen opened this issue Apr 10, 2024 · 2 comments
Open

Run React Native integration tests in more configurations #6604

kraenhansen opened this issue Apr 10, 2024 · 2 comments

Comments

@kraenhansen
Copy link
Member

In the context of reactwg/react-native-new-architecture#167 (reply in thread) I suggest we start running our integration tests with different values for "hermes", "new arch" and "bridgeless". Since this adds complexity, multiplying the risk of some test failing as a result of any unstable test, running these additional tests should probably require a manual dispatch or a special label on the PR.

These configurations can be controlled by setting different values of the environment variables declared here (seems we're missing bridgeless for iOS):

"ORG_GRADLE_PROJECT_newArchEnabled": {
"external": true,
"default": "true"
},
"ORG_GRADLE_PROJECT_hermesEnabled": {
"external": true,
"default": "true"
},
"ORG_GRADLE_PROJECT_bridgelessEnabled": {
"external": true,
"default": "false"
}

"USE_HERMES": {
"external": true,
"default": "1"
},
"RCT_NEW_ARCH_ENABLED": {
"external": true,
"default": "1"
}

@kraenhansen kraenhansen added T-Internal no-jira-ticket Skip checking the PR title for Jira reference and removed no-jira-ticket Skip checking the PR title for Jira reference labels Apr 10, 2024
Copy link

sync-by-unito bot commented Apr 10, 2024

➤ PM Bot commented:

Jira ticket: RJS-2797

@kraenhansen
Copy link
Member Author

This draft PR is somewhat related: #5369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant