-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RJS-2810: Add privacy manifest for Apple App Store #6642
Draft
kneth
wants to merge
7
commits into
main
Choose a base branch
from
kneth/privacy-manifest
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneth
force-pushed
the
kneth/privacy-manifest
branch
from
May 1, 2024 09:57
8ef5f48
to
922c970
Compare
kneth
force-pushed
the
kneth/privacy-manifest
branch
from
May 3, 2024 14:20
1eed0df
to
a336be6
Compare
elle-j
reviewed
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a go 🙂
* [12.8.1-alpha.0] Bump version * [12.8.1-alpha.0] Bump version --------- Co-authored-by: kneth <kneth@users.noreply.github.com> Co-authored-by: Kenneth Geisshirt <k@zigzak.net>
Co-authored-by: kneth <kneth@users.noreply.github.com>
Co-authored-by: LJ <81748770+elle-j@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This closes #6638
The manifest
The actual privacy manifest is based on our current understanding of what is needed.
Testing
npm pack
is used to create atgz
filenpm install realm-x.y.z.tgz
cd ios && pod install
Unknowns
I am a bit uncertain if the proposed privacy manifest (in particular the location of it) is compatible with Catalyst.
☑️ ToDos
Compatibility
label is updated or copied from previous entryCOMPATIBILITY.md
package.json
s (if updating internal packages)Breaking
label has been applied or is not necessary