You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed some @group … directives not being adapted and after a bit debugging I notice that in \Rector\PHPUnit\AnnotationsToAttributes\Rector\Class_\AnnotationWithValueToAttributeRector::refactor the call to getTagsByName returned DoctrineAnnotationTagValueNode instead of GenericTagValueNode.
But there is this check which makes it not pass:
if (!$desiredTagValueNode->value instanceof GenericTagValueNode) {
continue;
}
As to why: well, I've a (namespaces) class \Project\Models\Group imported in some tests and I guess rector treats the class Group special with @group. However, in my case there's no relation here and since the default config in annotations-to-attributes.php uses the FQCN anyway, there's no clash.
What can I do to still have such @group being converted?
I'm talking about using this in CI, so I'm not looking for a one-time transformation here.
Thanks
The text was updated successfully, but these errors were encountered:
Hi,
I noticed some
@group …
directives not being adapted and after a bit debugging I notice that in\Rector\PHPUnit\AnnotationsToAttributes\Rector\Class_\AnnotationWithValueToAttributeRector::refactor
the call togetTagsByName
returnedDoctrineAnnotationTagValueNode
instead ofGenericTagValueNode
.But there is this check which makes it not pass:
As to why: well, I've a (namespaces) class
\Project\Models\Group
imported in some tests and I guess rector treats the classGroup
special with@group
. However, in my case there's no relation here and since the default config inannotations-to-attributes.php
uses the FQCN anyway, there's no clash.What can I do to still have such
@group
being converted?I'm talking about using this in CI, so I'm not looking for a one-time transformation here.
Thanks
The text was updated successfully, but these errors were encountered: