Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing UI tests in test_pvc_ui.py #9795

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix failing UI tests in test_pvc_ui.py #9795

merged 1 commit into from
May 23, 2024

Conversation

sidhant-agrawal
Copy link
Contributor

Fixes: #9794

@sidhant-agrawal
Fix failures in test_pvc_ui.py
ac84b5b 
Signed-off-by: Sidhant Agrawal <sagrawal@redhat.com>
@sidhant-agrawal sidhant-agrawal added Squad/Green backport-required Mark for PRs that need to be backported to older release branches labels May 11, 2024
ocs-ci
ocs-ci reviewed May 11, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: sagrawal-m10
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/ui/test_pvc_ui.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

ocs-ci
ocs-ci reviewed May 11, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: sagrawal-v11
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/ui/test_pvc_ui.py
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job PASSED.

@sidhant-agrawal
Copy link
Contributor Author

Verified on both 4.16 and 4.15 cluster.
4.15 cluster (sagrawal-v11) was deployed with UI_DEPLOY parameter.
Marking PR as Verified.

@sidhant-agrawal sidhant-agrawal requested a review from a team May 12, 2024 03:26
@sidhant-agrawal sidhant-agrawal added the Verified Mark when PR was verified and log provided label May 12, 2024
@sidhant-agrawal sidhant-agrawal marked this pull request as ready for review May 12, 2024 03:26
@sidhant-agrawal sidhant-agrawal requested a review from a team as a code owner May 12, 2024 03:26
@openshift-ci openshift-ci bot added the lgtm label May 12, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: am-agrawa, DanielOsypenko, ebondare, jilju, paraggit, sidhant-agrawal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sidhant-agrawal sidhant-agrawal merged commit bb6bfc4 into red-hat-storage:master May 23, 2024
6 of 7 checks passed
@sidhant-agrawal
Copy link
Contributor Author

/cherrypick release-4.15

@openshift-cherrypick-robot
Copy link
Collaborator

@sidhant-agrawal: new pull request created: #9845

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 23, 2024
Merged
amr1ta pushed a commit to amr1ta/ocs-ci that referenced this pull request May 28, 2024
@sidhant-agrawal @amr1ta
Fix failures in test_pvc_ui.py (red-hat-storage#9795)
7313a8e 
Signed-off-by: Sidhant Agrawal <sagrawal@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@paraggit paraggit paraggit approved these changes

@jilju jilju jilju approved these changes

@ebondare ebondare ebondare approved these changes

@DanielOsypenko DanielOsypenko DanielOsypenko approved these changes

@am-agrawa am-agrawa am-agrawa approved these changes

Assignees

@paraggit paraggit

@jilju jilju

@ebondare ebondare

@DanielOsypenko DanielOsypenko

@am-agrawa am-agrawa

Labels
backport-required Mark for PRs that need to be backported to older release branches lgtm size/XS Squad/Green Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
8 participants
@sidhant-agrawal @openshift-cherrypick-robot @paraggit @jilju @ebondare @ocs-ci @DanielOsypenko @am-agrawa