Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negate overlapping args when -o flag is being used #137

Closed
black-dragon74 opened this issue Mar 13, 2024 · 0 comments · Fixed by #163
Closed

Negate overlapping args when -o flag is being used #137

black-dragon74 opened this issue Mar 13, 2024 · 0 comments · Fixed by #163
Assignees
@black-dragon74

Comments

@black-dragon74
Copy link
Collaborator

Negate the following flags if -o argument is detected as it will create redundancy and increase collection time unnecessarily.

--nooba
--ceph
--ceph-logs
--namespaced
--clusterscoped
@black-dragon74 black-dragon74 self-assigned this Mar 13, 2024
black-dragon74 added a commit to black-dragon74/odf-must-gather that referenced this issue May 28, 2024
@black-dragon74
Negate overlapping args with -o flag
4a31fa5 
Fixes: red-hat-storage#137

Right now if someone runs must-gather in odf mode
by using `-o` or `--odf` flag and also issues one
of `-c`, `-cl`, `-ns` or `-cs`, these scripts will
be executed twice, adding to the collection time and
creating redundant collection.

Essentially, this patch prevents execution of any of the
sub-scripts that are already called by `-o` flag.

Signed-off-by: black-dragon74 <niryadav@redhat.com>
@black-dragon74 black-dragon74 mentioned this issue May 28, 2024
Merged
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/odf-must-gather that referenced this issue May 28, 2024
@black-dragon74
Negate overlapping args with -o flag
37694ed 
Fixes: red-hat-storage#137

Right now if someone runs must-gather in odf mode
by using `-o` or `--odf` flag and also issues one
of `-c`, `-cl`, `-ns` or `-cs`, these scripts will
be executed twice, adding to the collection time and
creating redundant collection.

Essentially, this patch prevents execution of any of the
sub-scripts that are already called by `-o` flag.

Signed-off-by: black-dragon74 <niryadav@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@black-dragon74 black-dragon74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Negate overlapping args with -o flag black-dragon74/odf-must-gather
1 participant
@black-dragon74