Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "type" to "dataType" #69

Open
maZahaca opened this issue Apr 20, 2016 · 1 comment
Open

Rename "type" to "dataType" #69

maZahaca opened this issue Apr 20, 2016 · 1 comment
Milestone

Comments

@maZahaca
Copy link
Member

Sometime we need to specify data type in the parsed result.
For now this is a "type" field. But also we use "type" keyword as determine type of actions and transforms . So we need to rename "type" to "dataType" in cases when it has data type meaning.

@maZahaca maZahaca mentioned this issue Dec 23, 2016
@maZahaca maZahaca added this to the 0.5 milestone Apr 9, 2018
@danielelli
Copy link

Would wait.js be a good example of a field that needs dataType instead of type

"wait.js" line 72:

const { type, urlPattern } = event;

While the Actions folder mostly needs type?

"actionsFactory.js" line 57-60:

addAction(type, action) {
      if (typeof type !== 'string' || typeof action !== 'function') {
          throw new Error('addAction accept type as string and action if function which must return a promise');
     }
}

I would love to help in the completion of this issue, just need to know exactly which files would be needing dataType vs regular type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants