Consistency and automation indulgement #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebases the `buildah-oci-ta` Task on the `buildah` Task.
Makes it easier if all descriptions are the same to compare the output of the TA tool with the baseline from the human generated Tasks.
Makes it easier to compare the base Tasks with the tool generated Tasks, and makes the TA Tasks consistent.
For consistency with other TA Tasks.
The tool will find the `"$(workspaces.source.path)/source"` (quoted) in the base non-TA Task, and will replace the `$(workspaces.source.path)` with `/var/workdir`, so the resulting value will be the value from this commit. This is analogous to what Tekton Pipelines does for the variable substitution. Added so that the base-TA Task can be easily compared to the tool generated TA Task.
|
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details in the comments. This will allow the tool in enterprise-contract/hacks#82 to generate the equivalent TA variants to the human generated ones. Also helps that descriptions and volume usage is consistent, at least with this convention new TA Tasks would not diverge much.