Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tekton-tools update #993

Merged
merged 2 commits into from
May 29, 2024
Merged

tekton-tools update #993

merged 2 commits into from
May 29, 2024

Conversation

@rh-tap-build-team rh-tap-build-team bot force-pushed the tekton-tools branch 2 times, most recently from 00f6ce7 to 79de065 Compare May 7, 2024 05:12
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yftacherzog
Copy link
Contributor

/retest

@ralphbean
Copy link
Member

What's going on with d71df29? Is that intentional?

@ralphbean
Copy link
Member

This looks suspicious:

❯ skopeo inspect docker://quay.io/redhat-appstudio/hacbs-test:v1.1.8 | jq .Created  
"2023-12-11T09:15:35.79983516Z"
❯ skopeo inspect docker://quay.io/redhat-appstudio/konflux-test:v1.4.0 | jq .Created
"2024-04-18T19:13:12.069672974Z"

@yftacherzog
Copy link
Contributor

yftacherzog commented May 24, 2024

What's going on with d71df29? Is that intentional?

Good catch. Those tasks are maintained in tekton-tools repo, but in this case, an update was pushed to build-definitions directly instead of tekton-tools, so now the next update coming from tekton-tools is trying to revert the change.

@Omeramsc, can you replace the reference to the hacbs-test image with the one for the konflux-test image in tekton-tools? This should revert the change in this PR.

@yftacherzog
Copy link
Contributor

@Omeramsc can you have another look here to verify that you see all the changes you introduced in tekton-tools and nothing else?

@Omeramsc
Copy link

@yftacherzog It is LGTM
@ralphbean PTAL

@ralphbean ralphbean added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@Omeramsc
Copy link

@gbenhaim @tkdchen @zregvart Are you able to merge\get it back to the merge queue?
This change is crucial for fixing a major bug in the environment-provisioning pipeline

@ralphbean ralphbean added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 6fa633c May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants