chore: pin setup-envtest version at working commit to unblock content provider #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
kubernetes-sigs/controller-runtime#2693 broke the content provider while doing docker-build with following issue[1] In order to unblock the CI, we are pinning sigs.k8s.io/controller-runtime/tools/setup-envtest at previous working commit[2] [1]. kubernetes-sigs/controller-runtime#2720 [2]. kubernetes-sigs/controller-runtime@c7e1dc9 Signed-off-by: Hongwei Liu <hongliu@redhat.com>
hongweiliu17
force-pushed
the
setupenv_version
branch
from
bcbb19e
to
3a3e148
Compare
|
hongweiliu17
requested review from
Josh-Everett,
MartinBasti,
dirgim,
kasemAlem,
dheerajodha,
jsztuka and
14rcole
jsztuka
approved these changes
Mar 25, 2024
|
/retest |
|
/test integration-service-e2e |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
==========================================
- Coverage 72.60% 72.35% -0.26%
==========================================
Files 46 46
Lines 4454 4572 +118
==========================================
+ Hits 3234 3308 +74
- Misses 885 916 +31
- Partials 335 348 +13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes-sigs/controller-runtime#2693 broke
the content provider while doing docker-build with following issue[1]
In order to unblock the CI, we are pinning
sigs.k8s.io/controller-runtime/tools/setup-envtest at previous working commit[2]
[1]. kubernetes-sigs/controller-runtime#2720
[2]. kubernetes-sigs/controller-runtime@c7e1dc9
Signed-off-by: Hongwei Liu hongliu@redhat.com
Maintainers will complete the following section