Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: redis/go-redis
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v9.5.3
Choose a base ref
...
head repository: redis/go-redis
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v9.5.4
Choose a head ref
  • 17 commits
  • 22 files changed
  • 13 contributors

Commits on Jun 19, 2024

  1. Change redis version from 7.2 to 7.4 in makefile (#3034)

    * Change redis version from 7.2 to 7.4
    
    * fix jsonGet test
    
    * Add 'watch' to client info
    
    * Remove jsonGet from Enterprise tests
    ofekshenawa authored Jun 19, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    2a3de7e View commit details
  2. Support Hash-field expiration commands (#2991)

    * Add HExpire command
    
    * Add HPExpire, HexpireAt, HPExpireAt, HTTL, HPTTL, HPersist,HExpireTime, HPExpireTIme, HGetF, HSetF commands
    
    * add docstring
    
    * add tests and fix commands
    
    * modify commands
    
    * api changes
    
    * fix tests
    
    * remove tests from RE
    ofekshenawa authored Jun 19, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    a9b4c5c View commit details
  3. Added test case for CLIENT KILL with MAXAGE option (#2971)

    * Added test case for CLIENT KILL with MAXAGE option
    
    * Fixed sleep value
    
    * Added additional condition to kill specific connection
    
    * Test commit
    
    * Test commit
    
    * Updated test case to handle timeouts
    
    ---------
    
    Co-authored-by: ofekshenawa <104765379+ofekshenawa@users.noreply.github.com>
    vladvildanov and ofekshenawa authored Jun 19, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    0777247 View commit details
  4. Support NOVALUES parameter for HSCAN (#2925)

    * Support NOVALUES parameter for HSCAN
    
    Issue #2919
    
    The NOVALUES parameter instructs HSCAN to only return the hash keys,
    without values.
    
    * Update hash_commands.go
    
    ---------
    
    Co-authored-by: ofekshenawa <104765379+ofekshenawa@users.noreply.github.com>
    gerzse and ofekshenawa authored Jun 19, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    097cddb View commit details
  5. remove tests from RE (#3035)

    ofekshenawa authored Jun 19, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    445d266 View commit details

Commits on Jun 20, 2024

  1. Add support for XREAD last entry (#3005)

    * add support for XREAD last entry
    
    * handle reading from multiple streams
    
    * add test to ensure we block for empty stream
    
    * small tweak
    
    * add an option to XReadArgs instead
    
    * modify test comment
    
    * small preallocation optimization
    
    * Changed argument to generic ID, skip tests on Enterprise
    
    * Fix test case
    
    * Updated expiration command
    
    ---------
    
    Co-authored-by: Vladyslav Vildanov <117659936+vladvildanov@users.noreply.github.com>
    Co-authored-by: vladvildanov <divinez122@outlook.com>
    3 people authored Jun 20, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    3975cd5 View commit details

Commits on Jun 21, 2024

  1. chore(deps): bump golang.org/x/net in /example/otel (#3000)

    Bumps [golang.org/x/net](https://github.com/golang/net) from 0.20.0 to 0.23.0.
    - [Commits](golang/net@v0.20.0...v0.23.0)
    
    ---
    updated-dependencies:
    - dependency-name: golang.org/x/net
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Monkey <golang@88.com>
    dependabot[bot] and monkey92t authored Jun 21, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    fc4c8bd View commit details
  2. Add (*StatusCmd).Bytes() method (#3030)

    Signed-off-by: Andrew Haines <andrew@haines.org.nz>
    Co-authored-by: Monkey <golang@88.com>
    haines and monkey92t authored Jun 21, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    2d7382e View commit details

Commits on Jun 26, 2024

  1. RediSearch Support (#2801)

    * Add RediSearch Support
    
    * searach
    
    * Add RediSearch commands and tests
    
    * Adding more tests and fixing commands
    
    * Remove unnecessary additions
    
    * fixing tests
    
    * fixing tests
    
    * fixing tests
    
    * fixing FTConfig dialect test
    
    * fix commects
    
    * make enum for field types
    
    * Support resp 2
    
    * fix golang ci
    
    * fix ftinfo
    
    ---------
    
    Co-authored-by: Chayim <chayim@users.noreply.github.com>
    ofekshenawa and chayim authored Jun 26, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    244a3e2 View commit details

Commits on Jun 27, 2024

  1. chore(deps): bump rojopolis/spellcheck-github-actions (#3028)

    Bumps [rojopolis/spellcheck-github-actions](https://github.com/rojopolis/spellcheck-github-actions) from 0.36.0 to 0.38.0.
    - [Release notes](https://github.com/rojopolis/spellcheck-github-actions/releases)
    - [Changelog](https://github.com/rojopolis/spellcheck-github-actions/blob/master/CHANGELOG.md)
    - [Commits](rojopolis/spellcheck-github-actions@0.36.0...0.38.0)
    
    ---
    updated-dependencies:
    - dependency-name: rojopolis/spellcheck-github-actions
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Monkey <golang@88.com>
    dependabot[bot] and monkey92t authored Jun 27, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    daf84a0 View commit details

Commits on Jul 2, 2024

  1. Change monitor test to run manually (#3041)

    * Change monitor test to run manually
    
    * fix
    ofekshenawa authored Jul 2, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    4cf03db View commit details

Commits on Jul 5, 2024

  1. Update pubsub.go (#3042)

    Change context.Background() to ctx
    immersedin authored Jul 5, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    26e0c49 View commit details

Commits on Jul 10, 2024

  1. fix node routing in slotClosestNode (#3043)

    * fix node routing when all nodes are failing
    
    * fix minlatency zero value
    srikar-jilugu authored Jul 10, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    9c1f4f0 View commit details
  2. Support Hash-field expiration for 7.4 CE RC2 (#3040)

    Co-authored-by: Monkey <golang@88.com>
    Co-authored-by: Vladyslav Vildanov <117659936+vladvildanov@users.noreply.github.com>
    3 people authored Jul 10, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    6a584c1 View commit details

Commits on Jul 11, 2024

  1. Support Hash-field expiration commands in Pipeline & Fix HExpire HExp…

    …ireWithArgs expiration (#3038)
    
    * Support Hash-field expiration commands in Pipeline
    
    * Fix HExpire & HExpireWithArgs expiration
    
    * Fix HExpire & HPExpire Testcase
    
    * Update commands_test.go
    
    ---------
    
    Co-authored-by: ofekshenawa <104765379+ofekshenawa@users.noreply.github.com>
    Co-authored-by: Monkey <golang@88.com>
    3 people authored Jul 11, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    7539858 View commit details
  2. TimeSeries insertion filters for close samples (#3003)

    * TimeSeries insertion filters for close samples
    
    * fix
    
    * fix
    
    * fix
    
    * fix
    
    * fix
    
    ---------
    
    Co-authored-by: Vladyslav Vildanov <117659936+vladvildanov@users.noreply.github.com>
    ofekshenawa and vladvildanov authored Jul 11, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    8a0c59b View commit details

Commits on Jul 12, 2024

  1. add test for tls connCheck #3025 (#3047)

    * add a check for TLS connections.
    naiqianz authored Jul 12, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    0858ed2 View commit details
Showing with 4,292 additions and 46 deletions.
  1. +2 −1 .github/wordlist.txt
  2. +1 −1 .github/workflows/spellcheck.yml
  3. +1 −1 Makefile
  4. +66 −0 command.go
  5. +1 −0 commands.go
  6. +286 −0 commands_test.go
  7. +2 −2 example/otel/go.mod
  8. +4 −4 example/otel/go.sum
  9. +277 −1 hash_commands.go
  10. +5 −0 internal/pool/conn_check.go
  11. +18 −0 internal/pool/conn_check_test.go
  12. +45 −0 internal/util.go
  13. +16 −0 iterator_test.go
  14. +3 −3 json_test.go
  15. +11 −2 monitor_test.go
  16. +32 −10 osscluster.go
  17. +1 −1 pubsub.go
  18. +2,192 −0 search_commands.go
  19. +1,136 −0 search_test.go
  20. +7 −1 stream_commands.go
  21. +42 −14 timeseries_commands.go
  22. +144 −5 timeseries_commands_test.go
3 changes: 2 additions & 1 deletion .github/wordlist.txt
Original file line number Diff line number Diff line change
@@ -57,4 +57,5 @@ url
variadic
RedisStack
RedisGears
RedisTimeseries
RedisTimeseries
RediSearch
2 changes: 1 addition & 1 deletion .github/workflows/spellcheck.yml
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- name: Check Spelling
uses: rojopolis/spellcheck-github-actions@0.36.0
uses: rojopolis/spellcheck-github-actions@0.38.0
with:
config_path: .github/spellcheck-settings.yml
task_name: Markdown
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -31,7 +31,7 @@ build:

testdata/redis:
mkdir -p $@
wget -qO- https://download.redis.io/releases/redis-7.2.1.tar.gz | tar xvz --strip-components=1 -C $@
wget -qO- https://download.redis.io/releases/redis-7.4-rc2.tar.gz | tar xvz --strip-components=1 -C $@

testdata/redis/src/redis-server: testdata/redis
cd $< && make all
66 changes: 66 additions & 0 deletions command.go
Original file line number Diff line number Diff line change
@@ -573,6 +573,10 @@ func (cmd *StatusCmd) Result() (string, error) {
return cmd.val, cmd.err
}

func (cmd *StatusCmd) Bytes() ([]byte, error) {
return util.StringToBytes(cmd.val), cmd.err
}

func (cmd *StatusCmd) String() string {
return cmdString(cmd, cmd.val)
}
@@ -3783,6 +3787,65 @@ func (cmd *MapStringStringSliceCmd) readReply(rd *proto.Reader) error {
return nil
}

// -----------------------------------------------------------------------
// MapStringInterfaceCmd represents a command that returns a map of strings to interface{}.
type MapMapStringInterfaceCmd struct {
baseCmd
val map[string]interface{}
}

func NewMapMapStringInterfaceCmd(ctx context.Context, args ...interface{}) *MapMapStringInterfaceCmd {
return &MapMapStringInterfaceCmd{
baseCmd: baseCmd{
ctx: ctx,
args: args,
},
}
}

func (cmd *MapMapStringInterfaceCmd) String() string {
return cmdString(cmd, cmd.val)
}

func (cmd *MapMapStringInterfaceCmd) SetVal(val map[string]interface{}) {
cmd.val = val
}

func (cmd *MapMapStringInterfaceCmd) Result() (map[string]interface{}, error) {
return cmd.val, cmd.err
}

func (cmd *MapMapStringInterfaceCmd) Val() map[string]interface{} {
return cmd.val
}

func (cmd *MapMapStringInterfaceCmd) readReply(rd *proto.Reader) (err error) {
n, err := rd.ReadArrayLen()
if err != nil {
return err
}

data := make(map[string]interface{}, n/2)
for i := 0; i < n; i += 2 {
_, err := rd.ReadArrayLen()
if err != nil {
cmd.err = err
}
key, err := rd.ReadString()
if err != nil {
cmd.err = err
}
value, err := rd.ReadString()
if err != nil {
cmd.err = err
}
data[key] = value
}

cmd.val = data
return nil
}

//-----------------------------------------------------------------------

type MapStringInterfaceSliceCmd struct {
@@ -4997,6 +5060,7 @@ type ClientInfo struct {
PSub int // number of pattern matching subscriptions
SSub int // redis version 7.0.3, number of shard channel subscriptions
Multi int // number of commands in a MULTI/EXEC context
Watch int // redis version 7.4 RC1, number of keys this client is currently watching.
QueryBuf int // qbuf, query buffer length (0 means no query pending)
QueryBufFree int // qbuf-free, free space of the query buffer (0 means the buffer is full)
ArgvMem int // incomplete arguments for the next command (already extracted from query buffer)
@@ -5149,6 +5213,8 @@ func parseClientInfo(txt string) (info *ClientInfo, err error) {
info.SSub, err = strconv.Atoi(val)
case "multi":
info.Multi, err = strconv.Atoi(val)
case "watch":
info.Watch, err = strconv.Atoi(val)
case "qbuf":
info.QueryBuf, err = strconv.Atoi(val)
case "qbuf-free":
1 change: 1 addition & 0 deletions commands.go
Original file line number Diff line number Diff line change
@@ -220,6 +220,7 @@ type Cmdable interface {
ProbabilisticCmdable
PubSubCmdable
ScriptingFunctionsCmdable
SearchCmdable
SetCmdable
SortedSetCmdable
StringCmdable
Loading