Add helpers to set libinfo without panic #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c if we try to set both
ofekshenawa
previously approved these changes
Dec 17, 2023
ofekshenawa
approved these changes
Feb 14, 2024
ofekshenawa
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
the command
CLIENT SETINFOexpects lib name OR lib version and it we try to set both (or none) it will failto avoid this I add two small helpers that can return a valid
LibraryInfostruct that will never panics and it make the code readable (please check the examples)I did not add any breaking changes, just two new functions:
WithLibraryNameandWithLibraryVersion-- we can rename it if you want.I think this can mitigate any possible panic in runtime.
Regards