Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentinel with PubSub deadlocks on Close #2943

Open
danilobuerger opened this issue Mar 20, 2024 · 0 comments
Open

Sentinel with PubSub deadlocks on Close #2943

danilobuerger opened this issue Mar 20, 2024 · 0 comments

Comments

@danilobuerger
Copy link

When using the FailoverClient (Sentinel) with PubSub, calling Close will deadlock.

Expected Behavior

Close will close the PubSub and return.

Current Behavior

Close does not return.

Steps to Reproduce

func main() {
	client := redis.NewFailoverClient(&redis.FailoverOptions{
		MasterName:    "...",
		SentinelAddrs: []string{"..."},
	})

	pubSub := client.Subscribe(context.Background())
	pubSub.Channel()
	time.Sleep(1 * time.Second)
	log.Println("Subscribed")

	pubSub.Close()
	log.Println("Closed")
}

Version: 9.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant