Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline & Transaction with failover to multi cluster #3602

Merged
merged 19 commits into from
Nov 15, 2023

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Oct 30, 2023

Resolves #3568
closes #3594

to replace 'Base' classes; as the base classes don't have any implementation anymore
and so the word abstract better represents those classes.
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Attention: 94 lines in your changes are missing coverage. Please review.

Comparison is base (452ea52) 71.60% compared to head (d4545f6) 75.33%.

❗ Current head d4545f6 differs from pull request most recent head b631088. Consider uploading reports for the commit b631088 to get more accurate results

Files Patch % Lines
...ts/jedis/activeactive/MultiClusterTransaction.java 44.04% 43 Missing and 4 partials ⚠️
.../java/redis/clients/jedis/ReliableTransaction.java 77.33% 12 Missing and 5 partials ⚠️
...ients/jedis/activeactive/MultiClusterPipeline.java 46.87% 15 Missing and 2 partials ⚠️
...is/activeactive/CircuitBreakerCommandExecutor.java 61.53% 5 Missing ⚠️
src/main/java/redis/clients/jedis/Transaction.java 94.73% 2 Missing and 2 partials ⚠️
...tive/CircuitBreakerFailoverConnectionProvider.java 78.57% 3 Missing ⚠️
.../java/redis/clients/jedis/AbstractTransaction.java 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3602      +/-   ##
============================================
+ Coverage     71.60%   75.33%   +3.73%     
- Complexity     4883     4890       +7     
============================================
  Files           290      297       +7     
  Lines         15610    14963     -647     
  Branches       1115     1130      +15     
============================================
+ Hits          11178    11273      +95     
+ Misses         3946     3194     -752     
- Partials        486      496      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sazzad16 sazzad16 added the breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. label Nov 2, 2023
@sazzad16 sazzad16 requested a review from uglide November 2, 2023 13:18
}

public Transaction multi() {
public AbstractTransaction multi() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uglide @banker This is where we're having a breaking change.

@sazzad16 sazzad16 added this to the 5.1.0 milestone Nov 15, 2023
@sazzad16 sazzad16 merged commit 0d77298 into redis:master Nov 15, 2023
4 checks passed
@sazzad16 sazzad16 deleted the pipe-pipe-and-tx branch November 15, 2023 12:07
@qyi71
Copy link

qyi71 commented May 28, 2024

@sazzad16 in version 5.1.0 Transaction class no longer supported publish ?

@sazzad16
Copy link
Collaborator Author

@qyi71 No.

@qyi71
Copy link

qyi71 commented May 29, 2024

@qyi71 No.

right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. experimental
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for automatic failover in Pipeline
4 participants