Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isolationPoolOptions have terrible defaults #2720

Open
VivaLaPanda opened this issue Mar 15, 2024 · 0 comments
Open

isolationPoolOptions have terrible defaults #2720

VivaLaPanda opened this issue Mar 15, 2024 · 0 comments
Labels

Comments

@VivaLaPanda
Copy link

Description

Currently node-redis uses the same default options as GenericPool for isolationPoolOptions. Not only are the params poorly documented, the default parameters are not something you'd almost ever want. The default max pool size is 1, which means setting isolated: true has no effect.

The package should either set new defaults, or warn in the documentation to always configure these if using isolated: true.

Node.js Version

No response

Redis Server Version

No response

Node Redis Version

No response

Platform

No response

Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant