Skip to content

Replica one of arguments #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Replica one of arguments #394

merged 1 commit into from
Oct 23, 2023

Conversation

nirrattner
Copy link
Contributor

It looks like this isn't quite working at the moment, I may have misconfigured the JSON, or else I may have to look into the code generation next week to see exactly what is going on.

@rueian
Copy link
Collaborator

rueian commented Oct 19, 2023

Hi @nirrattner, thanks and I am sorry about that.

Could you help change the Walk function to this and generate those builders again?

func (n *node) Walk(fn func(node *node)) {
	next := n
	for next != nil {
		if next.Child != nil {
			next.Child.Walk(fn)
		} else {
			fn(next)
			if next.Arg.Type == "oneof" {
				for _, s := range next.GoStructs() {
					for _, ns := range s.NextNodes {
						ns.Walk(fn)
					}
				}
			}
		}
		next = next.Next
	}
}

@rueian
Copy link
Collaborator

rueian commented Oct 19, 2023

Never mind. I have updated it here 6ecaa43.

Please just rebase and regenerate.

Verified

This commit was signed with the committer’s verified signature.
carllerche Carl Lerche
@nirrattner nirrattner marked this pull request as ready for review October 23, 2023 13:59
@nirrattner
Copy link
Contributor Author

Hey, sorry for the delay in getting this in, and thank you for doing all of the hard work of implementing and fixing the code generation. Last week was a bit hectic for me

@rueian rueian added the feature label Oct 23, 2023
@rueian
Copy link
Collaborator

rueian commented Oct 23, 2023

Hi @nirrattner, it’s ok. Thank you very much for your contribution!

@rueian rueian merged commit 73f72b4 into redis:main Oct 23, 2023
@nirrattner nirrattner deleted the replica-of-no-one branch October 24, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants