Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GearsCmdable to go-redis API adapter #395

Merged
merged 11 commits into from
Oct 20, 2023

Conversation

unknowntpo
Copy link
Contributor

This PR adds GearsCmdable to our go-redis API adapter, and copied the tests from go-redis to make sure that it's compatible.

@unknowntpo unknowntpo force-pushed the feat-align-rueidis-with-go-redis-gear branch from 6810129 to 87a4053 Compare October 20, 2023 10:49
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (55961cc) 97.56% compared to head (53eef52) 97.51%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
- Coverage   97.56%   97.51%   -0.06%     
==========================================
  Files          76       76              
  Lines       30737    30848     +111     
==========================================
+ Hits        29990    30082      +92     
- Misses        627      641      +14     
- Partials      120      125       +5     
Files Coverage Δ
internal/cmds/gen_triggers_and_functions.go 100.00% <100.00%> (ø)
rueidiscompat/adapter.go 95.07% <92.30%> (-0.10%) ⬇️
rueidiscompat/command.go 78.83% <60.60%> (-0.39%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rueian rueian merged commit 94323fd into redis:main Oct 20, 2023
@rueian
Copy link
Collaborator

rueian commented Oct 20, 2023

Thank you for your contribution! @unknowntpo

@unknowntpo
Copy link
Contributor Author

Thanks for reviewing my code, @rueian.

@unknowntpo unknowntpo deleted the feat-align-rueidis-with-go-redis-gear branch October 20, 2023 23:43
@rueian rueian added the feature label Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants