refactor: distribute slots to replicas #398
Merged
+136
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 76 76
Lines 30866 30868 +2
=======================================
+ Hits 30098 30100 +2
Misses 641 641
Partials 127 127
☔ View full report in Codecov by Sentry. |
rueian
reviewed
Oct 31, 2023
cluster.go
Outdated
| for _, slot := range g.slots { | ||
| for i := slot[0]; i <= slot[1]; i++ { | ||
| var cc conn | ||
| if c.opt.ReplicaOnly && nodesCount > 1 { |
There was a problem hiding this comment.
Hi @proost,
Your change looks good to me generally. However, I am concerned about this repeatness of the if statement inside each slot range.
I wonder whether it would be better if we moved the check to the outer block:
for master, g := range groups {
if c.opt.ReplicaOnly && len(g.nodes) > 1 {
for _, slot := range g.slots {
for i := slot[0]; i <= slot[1]; i++ {
slots[i] = conns[g.nodes[1+rand.Intn(len(g.nodes)-1)]]
}
}
} else {
for _, slot := range g.slots {
for i := slot[0]; i <= slot[1]; i++ {
slots[i] = conns[master]
}
}
}
}There was a problem hiding this comment.
Okay. I change it. 29c152a
There was a problem hiding this comment.
Hi @proost, thank you for your contribution! It looks great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve: #397
randomly pick one of replicas for a slot