Skip to content

feat: allow setting expiry on om entities by adding an exat field #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

rueian
Copy link
Collaborator

@rueian rueian commented Nov 29, 2023

Ref: #383

@rueian rueian changed the title feat: allow setting expiry on entities of the om by adding an exat field feat: allow setting expiry on om entities by adding an exat field Nov 29, 2023
@rueian rueian force-pushed the om-ttl branch 4 times, most recently from 7f10ac0 to 06b7969 Compare November 29, 2023 14:27

Verified

This commit was signed with the committer’s verified signature.
carllerche Carl Lerche
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (65f7055) 97.02% compared to head (0255319) 97.00%.

Files Patch % Lines
om/conv.go 70.00% 4 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
- Coverage   97.02%   97.00%   -0.03%     
==========================================
  Files          76       76              
  Lines       31556    31596      +40     
==========================================
+ Hits        30617    30649      +32     
- Misses        792      797       +5     
- Partials      147      150       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Verified

This commit was signed with the committer’s verified signature.
carllerche Carl Lerche

Verified

This commit was signed with the committer’s verified signature.
carllerche Carl Lerche
@rueian rueian added the feature label Dec 1, 2023
@rueian rueian merged commit 7654a00 into main Dec 1, 2023
@rueian rueian deleted the om-ttl branch December 15, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants