Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect rueidisotel.MetricAttrs options, and avoid copy them repeatedly #471

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

rueian
Copy link
Collaborator

@rueian rueian commented Feb 17, 2024

Fixes #463

@rueian rueian added the bug Something isn't working label Feb 17, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d21559) 95.66% compared to head (f3cfb13) 95.65%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
- Coverage   95.66%   95.65%   -0.01%     
==========================================
  Files          63       63              
  Lines       31765    31765              
==========================================
- Hits        30387    30384       -3     
- Misses       1184     1185       +1     
- Partials      194      196       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rueian rueian merged commit 0b3eda8 into main Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetricAttrs() does not add KeyValue attributes to the metrics
2 participants