-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine the .circleci/config.yml by using dynamic config #517
Conversation
Signed-off-by: moonorange <monoma632@gmail.com>
generate_config.sh
Outdated
list=\$(go list ./... | circleci tests split --split-by=timings) | ||
echo "Test Packages: \$list" | ||
for n in {1..5}; do | ||
../dockertest.sh \$list && break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need special handling here for the root module. The root module should use ./dockertest.sh
instead of ../dockertest.sh
.
e316773
to
8c17358
Compare
Signed-off-by: moonorange <monoma632@gmail.com>
8c17358
to
4455e48
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
==========================================
+ Coverage 95.57% 95.60% +0.03%
==========================================
Files 80 80
Lines 33178 33178
==========================================
+ Hits 31710 31720 +10
+ Misses 1267 1258 -9
+ Partials 201 200 -1 ☔ View full report in Codecov by Sentry. |
generate_config.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @moonorange! LGTM and is it possible to move the generate_config.sh to the .circleci folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: moonorange <monoma632@gmail.com>
78d6697
to
2e9c449
Compare
Description
Attempted to remove repetitive statements in ci by using dynamic config
Encountered problem
Use of setup workflows must be enabled in project settings (Project settings > Advanced -> Dynamic config using setup workflows)
I lack the necessary permissions to modify project settings. However, adjusting this setting is necessary for debugging the CI workflow effectively as I don't have an environment to run this locally.
Related Issue
#482
The Result of the shell script
sh generate_config.sh