Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade otel package dependencies #550

Merged
merged 2 commits into from
May 29, 2024
Merged

Upgrade otel package dependencies #550

merged 2 commits into from
May 29, 2024

Conversation

VladyslavLukyanenko
Copy link
Contributor

No description provided.

Verified

This commit was signed with the committer’s verified signature.
j178 Jo
@rueian
Copy link
Collaborator

rueian commented May 28, 2024

Hi @VladyslavLukyanenko, the go 1.20 in go.mod files should also be changed to go 1.21.

Verified

This commit was signed with the committer’s verified signature.
j178 Jo
@VladyslavLukyanenko
Copy link
Contributor Author

Hi @VladyslavLukyanenko, the go 1.20 in go.mod files should also be changed to go 1.21.

Done!

@rueian
Copy link
Collaborator

rueian commented May 28, 2024

Thanks @VladyslavLukyanenko! Are there any otel API changes we should be aware of?

@VladyslavLukyanenko
Copy link
Contributor Author

Thanks @VladyslavLukyanenko! Are there any otel API changes we should be aware of?

I'm not too sure, but I was unable to run the redis otel package with my other packages, since the schema url was different in here than in my other packages it was throwing merge conflict

@rueian
Copy link
Collaborator

rueian commented May 28, 2024

What schema url are you referring to?

@VladyslavLukyanenko
Copy link
Contributor Author

What schema url are you referring to?

Basically if we have a library that uses an older version of otel, and another library uses a newer one, it tries to merge the schemas

open-telemetry/opentelemetry-go#4476
open-telemetry/opentelemetry-go#4476 (comment)

@rueian rueian merged commit 55e5259 into redis:main May 29, 2024
12 checks passed
@rueian
Copy link
Collaborator

rueian commented May 29, 2024

Thanks @VladyslavLukyanenko! A new version will be released this week.

cyuankuo pushed a commit to cyuankuo/rueidis that referenced this pull request Jun 3, 2024
@VladyslavLukyanenko VladyslavLukyanenko deleted the vlad/upgrade-dependencies branch June 21, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants