Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSGi MANIFEST.MF headers should specify optional dependencies #5774

Closed
TomasTokaMrazek opened this issue Apr 11, 2024 · 4 comments
Closed

OSGi MANIFEST.MF headers should specify optional dependencies #5774

TomasTokaMrazek opened this issue Apr 11, 2024 · 4 comments
Labels
Milestone

Comments

@TomasTokaMrazek
Copy link

Optional packages listed in https://github.com/redisson/redisson/wiki/15.-Dependency-list should also be optional under Import-Package header. Right now basically every dependency is needed at runtime in OSGi environments, even if unused.

Simmilar issue already merged and closed.
#5674

@TomasTokaMrazek
Copy link
Author

I am currently wrapping redisson in custom OSGi bundle.

Kryo, Reactor, Jackson and Netty libraries are part of classpath as separate bundles.

This is my wrapper configuration for bnd. I guess the same can be added to pom.

Import-Package: \
    io.reactivex.rxjava3.*;resolution:=optional, \
    javax.cache.*;resolution:=optional, \
    jodd.*;resolution:=optional, \
    net.bytebuddy.*;resolution:=optional, \
    org.jboss.marshalling.*;resolution:=optional, \
    org.springframework.*;resolution:=optional, \
    *

The Import-Package clausule is missing packages for Reactor and Kryo library, as they are already availible in classpath. If Kryo packages should be marked as optional or required is up to debate.

@mrniko mrniko added this to the 3.28.1 milestone Apr 17, 2024
@mrniko mrniko added the bug label Apr 17, 2024
@mrniko
Copy link
Member

mrniko commented Apr 17, 2024

Thanks for pointing out and the details. Fixed

@mrniko mrniko closed this as completed Apr 17, 2024
@TomasTokaMrazek
Copy link
Author

@mrniko Just a heads up, looking at the commit. Package io.projectreactor should also be included as optional per https://github.com/redisson/redisson/wiki/15.-Dependency-list.

It was missing from my example, becuase I had the package in classpath.

@mrniko mrniko reopened this Apr 23, 2024
@mrniko mrniko modified the milestones: 3.29.0, 3.29.1 Apr 23, 2024
@mrniko
Copy link
Member

mrniko commented May 10, 2024

Fixed

@mrniko mrniko closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants