Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary rerenders after update to 8.1.0 from 7.4.2 #4360

Open
aizerin opened this issue Jan 16, 2019 · 3 comments
Open

Unnecessary rerenders after update to 8.1.0 from 7.4.2 #4360

aizerin opened this issue Jan 16, 2019 · 3 comments

Comments

@aizerin
Copy link

aizerin commented Jan 16, 2019

Are you submitting a bug report or a feature request?

Bug Report

What is the current behavior?

In 8.1.0 each field is rerendered with user input to any field.

8 1 0

What is the expected behavior?

Works as expected in 7.4.2.

7 4 2

Sandbox Link

https://redux-form.com/8.1.0/examples/simple/
https://redux-form.com/7.4.2/examples/simple/

@aizerin aizerin changed the title Unnecessary rerenders after update to 8.1.0 from 7.2.4 Unnecessary rerenders after update to 8.1.0 from 7.4.2 Jan 16, 2019
@mikew
Copy link

mikew commented Jan 17, 2019

I wonder if this has anything to do with using the new context stuff. Even the React team has something to say about them:

My personal summary is that new context is ready to be used for low frequency unlikely updates (like locale/theme).
facebook/react#14110 (comment)

@petrjaros
Copy link

This is probably caused by react-redux@6.0.0: reduxjs/react-redux#1164

@markerikson
Copy link

Note that in version 6.0, the wrapper components generated by connect() do their update work in render(). That means that they will re-render, even if your own component does not.

I've seen a couple other people report that the on-screen indicators seem to be flashing all the time. But, use of the React DevTools Profiler indicated that it was really only the specific connected components that were updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants