-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Styled-Components #1
Comments
I'm a little late to the party, but while Styled-Components are great, I'd opt on using javascript styles via Here's how we compose them with |
Thanks for your feedback. The main reason I didn't consider style based solutions is because I use some css-only features ( From your links I can see that const Panel = styled.div`
backrground-color: ${p => p.theme.base00}
` cc @mxstbr |
Yes, very much so! We export a <ThemeProvider theme={solarized}>
<App />
</ThemeProvider> Any component inside See more info at https://github.com/styled-components/styled-components#theming! |
Sounds great! We also can invert the theme before passing to |
Using @erikras' BTW, @mxstbr is there any utilities to convert scss or less into styled-components' tagged templates? For example, I'd like to use it for Sorry for off-top, I'm still investigating the solutions to implement theming for the extension. |
No worries! We (Jed is my boss) have been meaning to moving As far as Sass/Less utilities go, we're building |
We need this to release monitor's components in a npm package and make the them themables
The text was updated successfully, but these errors were encountered: