Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more benchmark apps #7

Open
markerikson opened this issue Sep 6, 2018 · 12 comments
Open

Add more benchmark apps #7

markerikson opened this issue Sep 6, 2018 · 12 comments

Comments

@markerikson
Copy link
Collaborator

We can start adding more benchmark apps now.

Pasting some other benchmark-ish repos that are worth investigating and potentially porting:

https://github.com/mweststrate/redux-todomvc
https://github.com/jscriptcoder/stressing-redux
https://github.com/somebody32/high-performance-redux/tree/gh-pages/assets
https://github.com/coderitual/redux-performance
reduxjs/react-redux#686 (comment)
https://github.com/Kalkut/redux-data-frequency-benchmark

Also, we should look at writing some more "real-world" benchmarks, not just FPS stress tests, but that may depend on figuring out what other metrics we want to measure (#3 ).

@markerikson
Copy link
Collaborator Author

Another potential source: the JS framework benchmarks repo at https://github.com/krausest/js-framework-benchmark .

@Avi98
Copy link

Avi98 commented Sep 28, 2018

@markerikson i can start implementing https://github.com/mweststrate/redux-todomvc and refer your stockticker benchmark example

@markerikson
Copy link
Collaborator Author

@Avi98: sure, go ahead, thanks!

@Avi98
Copy link

Avi98 commented Oct 6, 2018

Hi @markerikson, i need your help in providing some direction for setting up "react-redux-benchmarks" . I followed steps provided in the README.md. but while running this command " npm run initialize" i'm getting the following error. please help me. Thank you
screen shot 2018-10-04 at 11 33 50 pm

@markerikson
Copy link
Collaborator Author

Hmm. Not exactly sure what's going on there. Looks like NPM was having trouble copying a file during the install process. Does this happen every time?

@Avi98
Copy link

Avi98 commented Oct 7, 2018

Yes, steps i followed for setting up the project after cloning it from github
cd react-redux-benchmarks
npm install
npm run initialize
and its still showing the error i have deleted node modules reinstalled it but its no help. Any alternative.
Thank you

@dai-shi
Copy link

dai-shi commented Dec 24, 2018

@Avi98 I have the same error and end up with a patch. I'm not sure what is a problem. Hope it's somehow fixed.

diff.txt

git clone https://github.com/reduxjs/react-redux-benchmarks.git
cd react-redux-benchmarks
patch -p1 < ../diff.txt
npm install
npm run initialize
npm start

@dai-shi
Copy link

dai-shi commented Dec 24, 2018

Hm, it doesn't seem to work as expected. Sorry.

@dai-shi
Copy link

dai-shi commented Dec 24, 2018

It works now.

diff2.txt

git clone https://github.com/reduxjs/react-redux-benchmarks.git
cd react-redux-benchmarks
patch -p1 < ../diff2.txt
curl https://unpkg.com/react@16.6.0/umd/react.production.min.js > copy-to-public/react.production.min.js
npm install
npm run initialize
BENCHMARKS=twitter-lite npm start -s
Running benchmark twitter-lite
  react-redux version: 5.0.7
    Checking max FPS... (30 seconds)
    Running trace...    (30 seconds)
  react-redux version: 6.0-1000-4855c84
    Checking max FPS... (30 seconds)
    Running trace...    (30 seconds)

Results for benchmark twitter-lite:
┌──────────────────┬─────────┬───────────┬───────────┬──────────┬───────────────────────────────────────────────────────────────────────────────┐
│ Version          │ Avg FPS │ Scripting │ Rendering │ Painting │ FPS Values                                                                    │
├──────────────────┼─────────┼───────────┼───────────┼──────────┼───────────────────────────────────────────────────────────────────────────────┤
│ 5.0.7            │ 45.73   │ 20656.72  │ 3581.47   │ 373.67   │ 54,59,60,57,59,52,59,57,54,45,57,55,51,43,37,42,37,36,32,30,29,28,27          │
├──────────────────┼─────────┼───────────┼───────────┼──────────┼───────────────────────────────────────────────────────────────────────────────┤
│ 6.0-1000-4855c84 │ 31.76   │ 24595.08  │ 2232.00   │ 284.90   │ 49,60,55,59,47,58,49,48,39,35,32,30,29,25,22,24,23,22,21,16,18,17,18,17,16,14 │
└──────────────────┴─────────┴───────────┴───────────┴──────────┴───────────────────────────────────────────────────────────────────────────────┘

I'll file a new issue about the broken file.

@Avi98
Copy link

Avi98 commented Dec 24, 2018

hi @dai-shi, I don't remember but I think I removed all lock file and reinstalled then it started working.
What did you do?

@dai-shi
Copy link

dai-shi commented Dec 24, 2018

@Avi98 Is it that easy? I'll try it later.

Anyway, since I already posted a bunch of unrelated comments and you have no problem now,
I'll stop this topic here. If we need further discussions, let's open a new issue.

dai-shi added a commit to dai-shi/react-redux-benchmarks that referenced this issue Dec 26, 2018
@markerikson
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants