Skip to content

Commit

Permalink
Remove RTK peerDep
Browse files Browse the repository at this point in the history
  • Loading branch information
markerikson committed Jun 21, 2023
1 parent 5c76414 commit 44fc725
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
4 changes: 0 additions & 4 deletions package.json
Expand Up @@ -40,7 +40,6 @@
"coverage": "codecov"
},
"peerDependencies": {
"@reduxjs/toolkit": "^1 || ^2.0.0-beta.0",
"@types/react": "^16.8 || ^17.0 || ^18.0",
"@types/react-dom": "^16.8 || ^17.0 || ^18.0",
"react": "^16.8 || ^17.0 || ^18.0",
Expand All @@ -49,9 +48,6 @@
"redux": "^4 || ^5.0.0-beta.0"
},
"peerDependenciesMeta": {
"@reduxjs/toolkit": {
"optional": true
},
"@types/react": {
"optional": true
},
Expand Down
3 changes: 0 additions & 3 deletions yarn.lock
Expand Up @@ -8931,16 +8931,13 @@ __metadata:
typescript: ^4.3.4
use-sync-external-store: ^1.0.0
peerDependencies:
"@reduxjs/toolkit": ^1 || ^2.0.0-beta.0
"@types/react": ^16.8 || ^17.0 || ^18.0
"@types/react-dom": ^16.8 || ^17.0 || ^18.0
react: ^16.8 || ^17.0 || ^18.0
react-dom: ^16.8 || ^17.0 || ^18.0
react-native: ">=0.59"
redux: ^4 || ^5.0.0-beta.0
peerDependenciesMeta:
"@reduxjs/toolkit":
optional: true
"@types/react":
optional: true
"@types/react-dom":
Expand Down

3 comments on commit 44fc725

@ryota-murakami
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markerikson ```json
"@reduxjs/toolkit": {
"optional": true
},


This cause show 'unmet peer dependency' massage while npm install?

@markerikson
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryota-murakami I added that thinking it would maybe help in general, but it ended up breaking some Yarn Workspaces setups:

#2020

@ryota-murakami
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markerikson Wow, it's crazy move... Thanks!

Please sign in to comment.