Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create create-listener-collection package #1049

Closed
Andarist opened this issue Oct 17, 2018 · 1 comment
Closed

Create create-listener-collection package #1049

Andarist opened this issue Oct 17, 2018 · 1 comment

Comments

@Andarist
Copy link
Contributor

function createListenerCollection() {
// the current/next pattern is copied from redux's createStore code.
// TODO: refactor+expose that code to be reusable here?

Would you be interested in me working on this one? Would be cool to share this code between redux & react-redux. Also I could potentially reuse it in redux-saga as we have our own implementation of this copied & tweaked from redux.

@timdorr
Copy link
Member

timdorr commented Oct 17, 2018

This code is going to be going away in 6.0: https://github.com/reduxjs/react-redux/pull/1000/files#diff-aef7770e642ef4054826f6c0aab908c8 (It's also gone in #995 too).

Feel free to crib it for your own usage, but it looks like we're not going to need it here much longer.

@timdorr timdorr closed this as completed Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants