Fix issue with isValidElementType invariant check crashing on valid t… #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-redux-docs ready! Built with commit 8d3af26 |
|
Can you run this through Prettier? And can you add a test? |
…ype with circular structure
Andarist
force-pushed
the
fix/invariant-circular-type
branch
from
1fe203a
to
8d3af26
Compare
Andarist
commented
Dec 13, 2018
| @@ -27,4 +27,7 @@ if (version.toLowerCase() === 'all') { | |||
| } | |||
| } | |||
|
|
|||
| npmRun.execSync(`jest -c '${JSON.stringify(jestConfig)}'`, { stdio: 'inherit' }) | |||
| npmRun.execSync( | |||
| `jest -c '${JSON.stringify(jestConfig)}' ${process.argv.slice(2).join(' ')}`, | |||
There was a problem hiding this comment.
this has actually allowed me to use --watch (which is still not ideal because we have to edit copy of tests rather than real test files to benefit from that, but better this now than nothing)
Andarist
commented
Dec 13, 2018
| @@ -42,12 +42,12 @@ npm run test | |||
|
|
|||
| To run in explicit React versions (the number is the version, so `test:16.3` will run in React version `16.3`): | |||
| ``` | |||
| REACT=16.4 npm run test:ci | |||
| REACT=16.4 npm run test | |||
There was a problem hiding this comment.
there is no test:ci script
Done & done. |
|
Thanks for this and the other updates! |
webguru7
pushed a commit
to webguru7/react-redux
that referenced
this pull request
Dec 8, 2022
…ype with circular structure (reduxjs#1122)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ype with circular structure
Repro - https://codesandbox.io/s/jnmoxr5mk3
Emotion is attaching created component to the returned styled component (creating a circular structure) to easily "flatten" subsequent calls wrapping that component, as in: