Minor optimization: remove conditional #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditional in selectDerivedProps is unnecessary. The code behaves identically now but saves about 10% of performance for that portion of the function. See: https://jsperf.com/conditional-vs-not Code left in place but commented in case someone ever wants to add something like it back for "clarity".
|
Deploy preview for react-redux-docs ready! Built with commit 7da8c0d |
|
Thanks! |
webguru7
pushed a commit
to webguru7/react-redux
that referenced
this pull request
Dec 8, 2022
* Minor optimization: remove conditional The conditional in selectDerivedProps is unnecessary. The code behaves identically now but saves about 10% of performance for that portion of the function. See: https://jsperf.com/conditional-vs-not Code left in place but commented in case someone ever wants to add something like it back for "clarity". * Just remove the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditional in selectDerivedProps is unnecessary. The code behaves
identically now but saves about 10% of performance for that portion of
the function.
See: https://jsperf.com/conditional-vs-not
Code left in place but commented in case someone ever wants to add
something like it back for "clarity".