Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isPlainObject() util returns is still incorrect #1207

Closed
alex89lj opened this issue Mar 21, 2019 · 1 comment
Closed

isPlainObject() util returns is still incorrect #1207

alex89lj opened this issue Mar 21, 2019 · 1 comment

Comments

@alex89lj
Copy link

alex89lj commented Mar 21, 2019

I am glad that this fix was merged(#1075), but it seems to be not perfect.
isPlainObject(Object.create(null))=>true,
isPlainObject(Object.create({}))=>false???.
image
This is correct in redux's "isPlainObject" function.
This is my PR:https://github.com/reduxjs/react-redux/pull/1005/files

@timdorr
Copy link
Member

timdorr commented Mar 21, 2019

Please see #1074 for why we accepted that change and Mark's comments here for why we don't need to be exhaustive with our checks: #1005 (comment)

@timdorr timdorr closed this as completed Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants