New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Maximum call stack size exceeded" when using v7 with redux saga #1227
Comments
Yipes, what a long stack trace. I'm afraid I really don't see anything useful out of that info. Unfortunately, I don't think there's much we can do here without some kind of a reproduction. |
Based on some googling, it looks like something else in your stack is doing a We now use One thing to try is setting |
I have the same issue but with a little bit smaller stacktrace and with a reproduction/project. It happens in all of our projects but we have one open source demo project based on the same tech and libraries: And deployed site is: The error also happens only in production. |
I don't use redux-saga and I see a similar issue on react-production build |
Can folks running into it try out the |
I put |
Can you provide a repro? |
same here, removing react-helmet from application fixed the problem. I'll try to reproduce/isolate my case but @timdorr is right, there's anything to do here. |
I'm having the same issue but I'm not using redux-saga. Here is the error:
Here is my package.json {
"firebase": "^5.9.4",
"jump.js": "^1.0.2",
"react": "^16.8.6",
"react-app-polyfill": "^0.2.2",
"react-dom": "^16.8.6",
"react-helmet": "^5.2.0",
"react-icons": "^3.5.0",
"react-markdown": "^4.0.6",
"react-redux": "^7.0.1",
"react-router-dom": "^5.0.0",
"react-scripts": "^2.1.8",
"redux": "^4.0.1",
"redux-form": "^8.2.0",
"redux-logger": "^3.0.6",
"redux-thunk": "^2.3.0"
} |
Please take this up with react-helmet |
Ok. Just fyi, I tried to use
Had to revert to react-redux v6.x |
I had the same issue. Only happens in production.
helps for now. |
I had the same issue. Only happens in production. |
Removing react-helmet from my project solved the issue for me. |
In my case I was using const dropDownItems = [
{value: 1, label: '1 year'},
{value: 2, label: <span> 2 years <PremiumBadge /></span>},
...
] so when I convert my JSX items to string like and render dropdown value with |
Hi! I'm not sure what useful information I can provide to help diagnose this issue, but in my app I've just recently upgraded to
react-redux@7
and started getting the error in the title. I've attached a log from the Chrome developer console and expanded the full stack trace. Note that this only seems to be occurring whenNODE_ENV === 'production'
. To reiterate: this error does not occur in v6React: 16.8.6
React-DOM: 16.8.6
Redux: 4.0.1
React-Redux: 7.0.1
Redux-Saga: 1.0.2
Formik: 1.5.2
Firebase: 5.9.2
@sentry/browser: 5.0.5
This issue occurs when saving a Formik form, dispatching an action, which is then handled in Redux-Saga. Redux-Saga creates a saga, converts it to a promise, and then runs the promise as a Cloud Firestore transaction.
Based on the stack trace, it seems like an error is occurring in the new
batch
method, which is sending the error up and getting caught in acomponentDidCatch
function at the top of my app. This error is then being reported by Sentry. Here's a small sample of the code I'm using... sadly, I don't really have the time at the moment to create a repo that isolates the issue.Saga code:
Firestore code:
And the stack trace from the chrome console logger
The text was updated successfully, but these errors were encountered: