Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix timing issue with setting up store subscription inside a connected component #1235

Merged
merged 1 commit into from Apr 12, 2019

Conversation

MrWolfZ
Copy link
Contributor

@MrWolfZ MrWolfZ commented Apr 12, 2019

This is a fix for #1226.

@netlify
Copy link

netlify bot commented Apr 12, 2019

Deploy preview for react-redux-docs ready!

Built with commit e71e7f1

https://deploy-preview-1235--react-redux-docs.netlify.com

@timdorr
Copy link
Member

timdorr commented Apr 12, 2019

Perfect. Thanks!

@timdorr timdorr merged commit 7555eae into reduxjs:master Apr 12, 2019
@markerikson
Copy link
Contributor

Thanks. Given that there's a few other things that have popped up too, I'd like to investigate a bit further over the weekend before pushing out a new release.

@Andrekra
Copy link

I'm still having the issues. Although not anymore in my codesandbox example (mentioned here #1226 (comment)), my real life app does. It uses the same pattern, but with way more nesting. For version 7 it was working, and after adding some console.logs, I see the same error pattern (The connect of the a child components triggers even when parent prevents rendering). I'll investigate further and see if I can create a codesandbox of the problem.

@justincrow
Copy link

We are also experiencing the same issue with 7.0.2. I've tried to re-create with a minimal example in codesandbox, but I cannot get the same error. I'll keep trying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants