Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Tutorial - Actions and Reducers source code not consistent #1594

Closed
zarasyversen opened this issue Jun 23, 2020 · 4 comments
Closed

Basic Tutorial - Actions and Reducers source code not consistent #1594

zarasyversen opened this issue Jun 23, 2020 · 4 comments

Comments

@zarasyversen
Copy link

Hi! 馃憢
I just completed the basic tutorial and got a bit confused as the source code files on the Actions and Reducers steps does not match the final code shown in complete source code. This stops the todo list from working properly (if you only follow the steps) once you reach the end of the tutorial.

https://redux.js.org/basics/basic-tutorial

Actions

Actions Step: https://redux.js.org/basics/actions#actionsjs
Actions - Complete code: https://redux.js.org/basics/example#actionsindexjs

The step is missing setting the id in addTodo.

Reducers

Reducers Step: https://redux.js.org/basics/reducers#reducersjs
Reducers - Complete (and split up): https://redux.js.org/basics/example#reducerstodosjs

The step is missing id as well in 'ADD_TODO'.

@markerikson
Copy link
Contributor

Yeah, the various example pages and snippets have been edited by different people at different times.

I'm planning to rewrite the entire tutorial sequence in the near future, so it's not worth trying to make them consistent at this point.

@timdorr
Copy link
Member

timdorr commented Jun 23, 2020

Yep, follow up in #1574

@timdorr timdorr closed this as completed Jun 23, 2020
@markerikson
Copy link
Contributor

Actually, the other issue is that this is the React-Redux repo, but the topic is the Redux core tutorial.

@zarasyversen
Copy link
Author

Ohhhh I am in the completely wrong repo! Don't know how that happened 馃槀 Sorry about that @markerikson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants