Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import bindActionCreators from redux #1705

Merged
merged 3 commits into from Mar 30, 2021
Merged

Import bindActionCreators from redux #1705

merged 3 commits into from Mar 30, 2021

Conversation

timdorr
Copy link
Member

@timdorr timdorr commented Mar 30, 2021

Closes #1498

This removes our peer dep on Redux itself. Technically, anything that implements the Redux API/behaviors should work A-OK with React Redux.

This also makes it easy to work with different version of Redux, if we eventually get to releasing 5.0. Less scary warnings from npm/yarn.

@github-actions
Copy link

Size Change: +104 B (0%)

Total Size: 26.6 kB

Filename Size Change
dist/react-redux.js 21.3 kB +71 B (0%)
dist/react-redux.min.js 5.25 kB +33 B (0%)

compressed-size-action

@netlify
Copy link

netlify bot commented Mar 30, 2021

Deploy preview for react-redux-docs ready!

Built with commit d83be43

https://deploy-preview-1705--react-redux-docs.netlify.app

@timdorr
Copy link
Member Author

timdorr commented Mar 30, 2021

BTW, I got rid of the type guards, since we're already doing that before calling this function. I also removed the function-to-function option, since I don't think that's a valid code path we use anywhere.

@markerikson
Copy link
Contributor

Hah, was just about to ask about those two changes :)

Yeah, if we're already confident we've got the right shape, that should be fine.

@markerikson
Copy link
Contributor

(uh... side question: why does package-lock.json have a diff of 26K lines? :) )

@markerikson
Copy link
Contributor

Oh, did you bump NPM from v6 to v7? I've still been using v6 locally for everything. I guess at some point I may have to bite the bullet and upgrade that on my machine.

@timdorr
Copy link
Member Author

timdorr commented Mar 30, 2021

Yeah, I upgraded locally. It's backwards compatible with npm@6, so it shouldn't be a problem. If it starts flapping back and forth, I can revert back until the tooling catches up.

@timdorr timdorr merged commit f4ea60c into master Mar 30, 2021
@timdorr timdorr deleted the unbounded branch March 30, 2021 18:15
@hornta
Copy link

hornta commented Mar 31, 2021

I was just about to raise an issue about this, so glad I found out this was done 👍 is there an ETA on a new release with this change?

@markerikson
Copy link
Contributor

Tentatively in the next few days? Juggling a lot of things atm, but I'll see if I can get around to cutting 7.2.4.

@xty xty mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants