Verify that selector and equalityF of useSelector are functions #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-redux-docs ready! Built with commit bd42e4a |
timdorr
reviewed
Mar 31, 2021
| } | ||
| if (typeof equalityFn !== 'function') { | ||
| throw new Error( | ||
| `You must pass a function as an equality function to useSelector` |
There was a problem hiding this comment.
Not going to lie, I would love to add a little sass on this one:
Suggested change
| `You must pass a function as an equality function to useSelector` | |
| `You must pass a _function_ as an equality _function_ to useSelector...` |
(Note, please don't merge this :P)
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1704 added a couple of dev-only checks to useSelector to verify that both selector and equalityFn are functions