Remove wrapActionCreators #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove wrapActionCreators.js and its associated test file, as it is no longer used anywhere in the codebase.
|
Deploy preview for react-redux-docs ready! Built with commit 2efa6f8 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1705.
After I had a look at the changes and a bit of digging, I came to realize
wrapActionCreatorshas not been used anywhere in the codebase since 5.x, so it's really just a dangling/unreachable file that should have been removed a long time ago.Now, the remaining question is whether we should move
bindActionCreatorsfromsrc/utils/bindActionCreators.jsintosrc/connect/mapDispatchToProps.jssince it is now the only place that referencesbindActionCreators. My own take would be to leave it as is.