Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing the latest version of this package results in yarn warnings about workspaces #1815

Closed
1 task done
kaiyoma opened this issue Sep 10, 2021 · 13 comments
Closed
1 task done

Comments

@kaiyoma
Copy link

kaiyoma commented Sep 10, 2021

What version of React, ReactDOM/React Native, Redux, and React Redux are you using?

  • React: 16.14.0
  • ReactDOM/React Native: 16.14.0
  • Redux: 4.0.5
  • React Redux: 7.2.5

What is the current behavior?

[3/4] Linking dependencies...
warning Workspaces can only be enabled in private projects.
warning Workspaces can only be enabled in private projects.
[4/4] Building fresh packages...

What is the expected behavior?

No warnings.

Which browser and OS are affected by this issue?

No response

Did this work in previous versions of React Redux?

  • Yes
@kaiyoma
Copy link
Author

kaiyoma commented Sep 10, 2021

Initially filed this against redux-devtools (reduxjs/redux-devtools#854), but the author there directed me to file the issue here.

The workspaces property can be easily found by searching through node_modules:

$ find node_modules/ -name package.json | xargs grep workspaces
node_modules/@redux-devtools/app/node_modules/react-redux/package.json:  "workspaces": [
node_modules/@redux-devtools/core/node_modules/react-redux/package.json:  "workspaces": [

@timdorr
Copy link
Member

timdorr commented Sep 11, 2021

Looks like this is caused by #1751. I guess they expect the top level workspace not to be published. Kind of a crappy requirement, IMHO. Maybe we can stripe this during publishing somehow?

@markerikson
Copy link
Contributor

Huh, that's... weird. And annoying. (Technically the problem would be #1810 for the v7 branch, but same difference.)

Well, couple options. The "workspaces" thing was only to add the docs folder so it all gets installed at once. Easy enough to drop that.

Alternately, we could do some silly "rewrite the package file before publishing" shenanigans or something.

@obaydmir
Copy link

Any solution for this issue?

@markerikson
Copy link
Contributor

@obaydmir Not exactly. We'd need to switch back to having the docs not be a "workspace", and do a new release. We're busy with a lot of other stuff atm and fixing this is not a high priority, especially given that it's just a single warning on install for a smaller portion of the userbase.

@obaydmir
Copy link

@obaydmir Not exactly. We'd need to switch back to having the docs not be a "workspace", and do a new release. We're busy with a lot of other stuff atm and fixing this is not a high priority, especially given that it's just a single warning on install for a smaller portion of the userbase.

I understand. No pressure. Not really a dealbreaker issue, just wanted to know the status. The info you have to send will place it in context and manage the expectations. We will have to wait for the perfect solution.

@rgoldfinger-quizlet
Copy link

No pressure, but I wanted to share what this looks like in our monorepo:

Screen Shot 2021-10-25 at 9 15 52 AM

@timdorr
Copy link
Member

timdorr commented Oct 25, 2021

I just published 7.2.6, which removes the workspace and should get rid of the warning.

@timdorr timdorr closed this as completed Oct 25, 2021
@rgoldfinger-quizlet
Copy link

Thank you so much! Certainly wasn't expecting it to be fixed so quickly, but it's much appreciated.

@markerikson
Copy link
Contributor

c'mon Tim now no one's gonna believe anything I say about scheduling or task prioritization if you keep fixing things this fast

@Gaphell
Copy link

Gaphell commented Nov 30, 2021

Screen Shot 2564-11-30 at 11 20 58 AM

I am seeing this in my workspace as well. Not sure if it's due to upgrading the webpack to v5.

@markerikson
Copy link
Contributor

@Gaphell Per above, this should have been fixed in 7.2.6. What version do you have installed?

@Gaphell
Copy link

Gaphell commented Nov 30, 2021

@Gaphell Per above, this should have been fixed in 7.2.6. What version do you have installed?

@markerikson, my bad, I was using 7.2.5. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants