Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for entities #989

Open
phihochzwei opened this issue Jan 4, 2022 · 4 comments · May be fixed by #1305 or #1608
Open

Search for entities #989

phihochzwei opened this issue Jan 4, 2022 · 4 comments · May be fixed by #1305 or #1608
Labels

Comments

@phihochzwei
Copy link

We are using the devtools in our project and they are really helpfull. But one thing is missing from my point of view: The possibility to search for an entity. We have e.g. one EntityState with roundabout 600 entities. It would be very helpfull if I could just enter the ID of a specific one to find it faster.

@FaberVitale
Copy link
Contributor

FaberVitale commented Jan 4, 2022

I think the best way to implement it is to add search functionality to redux-devtools-inspector-monitor right-side content.

I do not think that it makes sense in this case to use a monitor like we did for rtk-query-monitor.

@80avin
Copy link
Contributor

80avin commented Nov 28, 2022

I think I can help in this. I had implemented a search for my personal needs using jsonpath-plus and regex(broken).

Here's a sample run on https://drfhc8.csb.app/
image

Where original state is
image

If it's acceptable, I'll think on working on it. It is functional but needs work in

  • Refactoring.
  • jsonpath-plus uses eval for complex expressions, which doesn't work here (and is unsafe). So, need to see how to fix that.

@ximfritz
Copy link

I plan to also implement a search feature. It will maybe happen during a hackathon. Is there a chance that this feature will be accpeted as a PR?

@Methuselah96
Copy link
Member

Feel free to submit a PR. I don't have much time to work on redux-devtools, so if the PR is small and it's easy to tell it's implemented correctly, then it's more likely to get accepted and merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants