Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://github.com/reduxjs/redux/tree/master/examples/todos-flow Is outdated #3991

Closed
TomasBarry opened this issue Jan 8, 2021 · 2 comments

Comments

@TomasBarry
Copy link

What docs page needs to be fixed?

https://github.com/reduxjs/redux/tree/master/examples/todos-flow

What is the problem?

redux no longer exports the Store and Dispatch (or any) Flow types. Additionally, the version of flow-bin in this example is very far behind the latest version of flow-bin (0.142.0).

Second to this, actually running npm flow on a fresh build of this project results in 63 Flow errors.

What should be changed to fix the problem?

This example should be updated or removed if redux no longer intends to provide examples of using redux with Flow.

@timdorr
Copy link
Member

timdorr commented Jan 8, 2021

Yeah, I don't really know Flow and that was only added by contribution. We should probably remove it, given Flow's waning popularity.

@markerikson
Copy link
Contributor

Yeah, this issue is really a dupe of #3917 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants