Rewrite Redux core error messages #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added miniature port of `kindOf` for better `typeof` descriptions - Used `kindOf` for all runtime type check errors - Inlined "slice reducer returned undefined" error message - Rewrote "actions must be plain objects" error message to show the actual variable type and added tests - Reworded a bunch of error messages - Added some additional docs links - Updated tests that check error messages
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c83b014:
|
markerikson
changed the title
|
Size Change: +363 B (4%) Total Size: 8.58 kB
|
|
Deploy preview for redux-docs ready! Built with commit c83b014 |
6 tasks
msutkowski
reviewed
Apr 2, 2021
errors.json
Outdated
| "10": "Expected the nextReducer to be a function. Instead, received: '", | ||
| "11": "Expected the observer to be an object. Instead, received: ''", | ||
| "12": "The slice reducer for key \"\" returned undefined during initialization. If the state passed to the reducer is undefined, you must explicitly return the initial state. The initial state may not be undefined. If you don't want to set a value for this reducer, you can use null instead of undefined.", | ||
| "13": "The slice reducer for key \"\" returned undefined when probed with a random type. Don't try to handle or other actions in \"redux/*\" namespace. They are considered private. Instead, you must return the current state for any unknown actions, unless it is undefined, in which case you must return the initial state, regardless of the action type. The initial state may not be undefined, but can be null.", |
There was a problem hiding this comment.
Don't try to handle or other actions in "redux/*" namespace.
Is this missing a char or '' to get replaced that I'm not seeing?
There was a problem hiding this comment.
There's a template literal interpolation there:
`Don't try to handle ${ActionTypes.INIT} or other actionsand that doesn't get included in the extracted message.
I'll add single quotes around it, though.
markerikson
force-pushed
the
feature/update-error-messages
branch
from
ed6b5cc
to
c83b014
Compare
|
Going in! Next up, porting this whole set of changes to |
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
…sages Former-commit-id: 836784f
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 🐛 Bug fix or new feature
about: Fixing a problem with Redux
This PR:
errors.jsonfile with the updated errors, since none of our errors have been released yet