[Bug?]: Storybook preview config load not working #10113
Labels
bug/needs-info
More information is needed for reproduction
Comments
ChrisLFieldsII
added
the
bug/needs-info
ChrisLFieldsII
referenced
this issue
Mar 5, 2024
Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
|
Hey @ChrisLFieldsII Thanks for taking the time to file an issue and provide the screenshots. Those are a huge help. I'm going to pass your issue on to one of the core team members that specializes in Storybook and let you know what I find out. |
|
Hi @ChrisLFieldsII! I'm taking a look. Will keep you posted :) |
ChrisLFieldsII
changed the title
Josh-Walker-GM
pushed a commit
that referenced
this issue
Mar 9, 2024
Fixes #10113. I didn't see a pull request for this, but the fix seems to have already been identified in the linked issue and worked in my local testing.
jtoar
pushed a commit
that referenced
this issue
Mar 9, 2024
Fixes #10113. I didn't see a pull request for this, but the fix seems to have already been identified in the linked issue and worked in my local testing.
jtoar
pushed a commit
that referenced
this issue
Mar 9, 2024
Fixes #10113. I didn't see a pull request for this, but the fix seems to have already been identified in the linked issue and worked in my local testing.
|
Hi @ChrisLFieldsII! Just looping back here to check that you saw this was fixed. |
|
Yes! Amazing work. Much appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What's not working?
The code responsible for loading the storybook preview config is not working due to not using the correct path on the redwoodProjectPaths object
It looks like a recent change introduced this bug.
I attached a pic of the commit that I believe introduced this bug as well as a link
How do we reproduce the bug?
Create a bare redwood project with the provided
rw infoand add logs tostorybook.previewfile and notice the logs never show in the web dev console as they shouldI personally added logs to the
@redwoodjs/testingnode_module here and noticed that theifblock was never hit.Attached are before/after pics once I patched the
ifconditionBefore
After
What's your environment? (If it applies)
System: OS: macOS 14.2.1 Shell: 5.9 - /bin/zsh Binaries: Node: 20.11.1 - /private/var/folders/4h/7lryc_8j0dnddhpng25wx3dw0000gn/T/xfs-063fe80d/node Yarn: 4.1.0 - /private/var/folders/4h/7lryc_8j0dnddhpng25wx3dw0000gn/T/xfs-063fe80d/yarn Databases: SQLite: 3.43.2 - /usr/bin/sqlite3 Browsers: Chrome: 122.0.6261.94 Safari: 17.2.1 npmPackages: @redwoodjs/cli-storybook: 7.0.4 => 7.0.4 @redwoodjs/core: 7.0.4 => 7.0.4 @redwoodjs/project-config: 7.0.4 => 7.0.4Are you interested in working on this?
The text was updated successfully, but these errors were encountered: