fix(cli): Update build and serve to handle the absence of the api side #10265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
force-pushed
the
jgmw-fix/build-and-serve-without-api-side
branch
from
4c6c59e
to
33b068d
Compare
Josh-Walker-GM
force-pushed
the
jgmw-fix/build-and-serve-without-api-side
branch
from
33b068d
to
d9fa691
Compare
cannikin
approved these changes
Mar 21, 2024
1 task
thedavidprice
pushed a commit
that referenced
this pull request
Mar 27, 2024
#10265) **Problem** This PR address the issue raised in #10264 which highlighted that `yarn rw build` would fail for projects that have removed the `api` directory. **Changes** 1. The `yarn rw build` command now checks for the existence of the prisma schema file. It will not generate the prisma client if the file does not exist and it will not trigger prerendering if the schema file does not exist. 2. Updates the checks performed by `yarn rw serve` to handle the case when there is not API side a little nicer. It will offer more specific error messages when you run `yarn rw serve api` without an API side and it will tell you to run `yarn rw serve web` instead of `yarn rw serve` if you have no API side. **Concerns** 1. I'm not sure about adding checks for "does the API side even exist" anywhere we previously assumed it did. For now these checks only needed to happen in 2 places so I'm not that bothered about them but I can see how it could spiral out of control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR address the issue raised in #10264 which highlighted that
yarn rw buildwould fail for projects that have removed theapidirectory.Changes
yarn rw buildcommand now checks for the existence of the prisma schema file. It will not generate the prisma client if the file does not exist and it will not trigger prerendering if the schema file does not exist.yarn rw serveto handle the case when there is not API side a little nicer. It will offer more specific error messages when you runyarn rw serve apiwithout an API side and it will tell you to runyarn rw serve webinstead ofyarn rw serveif you have no API side.Concerns